https://github.com/chandlerc created https://github.com/llvm/llvm-project/pull/118736
Specifically, usernames containing `handle`, such as `chandlerc`, often end up in paths, including the path of this test file which contains the word `overflow`. Combined, they create a match for `handle.*overflow` in the filename on my system (but likely not many others), leading this test to mysteriously fail for unfortunate usernames like mine. =D No discussion of the amount of time I spent debugging this please. =[ >From 46633593ab1c6a7c997832b45872250f09dbc06a Mon Sep 17 00:00:00 2001 From: Chandler Carruth <chandl...@gmail.com> Date: Thu, 5 Dec 2024 03:11:42 +0000 Subject: [PATCH] Make the `CHECK` lines here resistent to `chandlerc` Specifically, usernames containing `handle`, such as `chandlerc`, often end up in paths, including the path of this test file which contains the word `overflow`. Combined, they create a match for `handle.*overflow` in the filename on my system (but likely not many others), leading this test to mysteriously fail for unfortunate usernames like mine. =D No discussion of the amount of time I spent debugging this please. =[ --- clang/test/CodeGen/ignore-overflow-pattern.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/clang/test/CodeGen/ignore-overflow-pattern.c b/clang/test/CodeGen/ignore-overflow-pattern.c index c4a9d07b07aaac..4e5ed82d7967ec 100644 --- a/clang/test/CodeGen/ignore-overflow-pattern.c +++ b/clang/test/CodeGen/ignore-overflow-pattern.c @@ -21,7 +21,10 @@ // unsigned negation, for example: // unsigned long A = -1UL; +// Skip over parts of the IR containing this file's name. +// CHECK: source_filename = {{.*}} +// Ensure we don't see anything about handling overflow before the tests below. // CHECK-NOT: handle{{.*}}overflow extern unsigned a, b, c; _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits