https://github.com/Backl1ght updated
https://github.com/llvm/llvm-project/pull/107768
>From 694b7dd640676c83a25e79b1f4ba1cb8e6cbb87b Mon Sep 17 00:00:00 2001
From: Backl1ght <backlight....@gmail.com>
Date: Sun, 1 Dec 2024 16:45:28 +0800
Subject: [PATCH] fix
---
clang/docs/ReleaseNotes.rst | 1 +
clang/lib/Sema/SemaOverload.cpp | 3 +++
clang/test/CXX/class.access/p4.cpp | 16 ++++++++++++++--
3 files changed, 18 insertions(+), 2 deletions(-)
diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst
index e44aefa90ab386..0de249ced8309a 100644
--- a/clang/docs/ReleaseNotes.rst
+++ b/clang/docs/ReleaseNotes.rst
@@ -763,6 +763,7 @@ Bug Fixes to C++ Support
- Fixed a bug where bounds of partially expanded pack indexing expressions
were checked too early. (#GH116105)
- Fixed an assertion failure caused by using ``consteval`` in condition in
consumed analyses. (#GH117385)
- Fix a crash caused by incorrect argument position in merging deduced
template arguments. (#GH113659)
+- Fix a bug where private access specifier of overloaded function not
respected. (#GH107629)
Bug Fixes to AST Handling
^^^^^^^^^^^^^^^^^^^^^^^^^
diff --git a/clang/lib/Sema/SemaOverload.cpp b/clang/lib/Sema/SemaOverload.cpp
index 4c9e37bd286dee..35389957adf32d 100644
--- a/clang/lib/Sema/SemaOverload.cpp
+++ b/clang/lib/Sema/SemaOverload.cpp
@@ -16305,6 +16305,9 @@ ExprResult Sema::FixOverloadedFunctionReference(Expr
*E, DeclAccessPair Found,
}
if (UnresolvedLookupExpr *ULE = dyn_cast<UnresolvedLookupExpr>(E)) {
+ if (Found.getAccess() == AS_none) {
+ CheckUnresolvedLookupAccess(ULE, Found);
+ }
// FIXME: avoid copy.
TemplateArgumentListInfo TemplateArgsBuffer, *TemplateArgs = nullptr;
if (ULE->hasExplicitTemplateArgs()) {
diff --git a/clang/test/CXX/class.access/p4.cpp
b/clang/test/CXX/class.access/p4.cpp
index ca98c9f90bd89e..6d4c8c004911db 100644
--- a/clang/test/CXX/class.access/p4.cpp
+++ b/clang/test/CXX/class.access/p4.cpp
@@ -21,11 +21,13 @@ namespace test0 {
public:
void foo(Public&);
protected:
- void foo(Protected&); // expected-note 2 {{declared protected here}}
+ void foo(Protected&); // expected-note 4 {{declared protected here}}
private:
- void foo(Private&); // expected-note 2 {{declared private here}}
+ void foo(Private&); // expected-note 4 {{declared private here}}
};
+ class B : public A {};
+
void test(A *op) {
op->foo(PublicInst);
op->foo(ProtectedInst); // expected-error {{'foo' is a protected member}}
@@ -35,6 +37,16 @@ namespace test0 {
void (A::*b)(Protected&) = &A::foo; // expected-error {{'foo' is a
protected member}}
void (A::*c)(Private&) = &A::foo; // expected-error {{'foo' is a private
member}}
}
+
+ void test(B *op) {
+ op->foo(PublicInst);
+ op->foo(ProtectedInst); // expected-error {{'foo' is a protected member}}
+ op->foo(PrivateInst); // expected-error {{'foo' is a private member}}
+
+ void (B::*a)(Public&) = &B::foo;
+ void (B::*b)(Protected&) = &B::foo; // expected-error {{'foo' is a
protected member}}
+ void (B::*c)(Private&) = &B::foo; // expected-error {{'foo' is a private
member}}
+ }
}
// Member operators.
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
