boomanaiden154 wrote:

> That and to also ensure that the edited Format.h doesn't break the python 
> script.

Makes sense. #118154 would cover that too.

> If we are to leave the generated part of the rst file in the repo, 
> https://github.com/llvm/llvm-project/pull/111513 would satisfy my 
> requirements nicely. Something like 
> https://github.com/llvm/llvm-project/pull/118154 may be a useful addition.

Can you explicate on what your requirements are here? I don't see why just 
wrapping the python script in CMake does anything tangible here. Having a build 
target that modifies the source directory is also weird and something that we 
should avoid if possible, in my opinion.

> That would be nice.

https://github.com/llvm/llvm-project/pull/118159

https://github.com/llvm/llvm-project/pull/113739
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to