https://github.com/5chmidti commented:

> Being totally unfamiliar with the code, I have a feeling that we shouldn't be 
> fixing in the analyze function. analyze has 1 single responsibility: wrap 
> `analyzeImpl` in order to add cacheability for performance reasons, it does 
> so simply and well, and it does exactly what one would expect - no more no 
> less.

This class could maintain a stack-like `SmallVector` to check for an infinite 
recursion., so instead of checking the function cache (which might be large), 
only a few functions have to be compared this way.

https://github.com/llvm/llvm-project/pull/66810
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to