goldsteinn wrote: > > All things considered, I think requiring `vc` is a lot less intrusive than > > essentially our own `vc` wrapper.... > > Not sure what you mean exactly by a wrapper, if git/diff logic can be > abstracted away - that seems a net gain. If ugly/fragile logic is required to > do that - it's debatable and may not be worth it (all things considered).
Well the wrapped is to hide the ugly git/diff stuff. > > Anyway, I was only mentioning that we could consider abstracting away the > logic - if it's not practical, there is no need to go into details discussing > it, although I did mail the emacs-devel mailing list to check if this might > be supported: My preference would be the get this in as is. https://github.com/llvm/llvm-project/pull/112792 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
