jhuber6 wrote:

> I'm not sure what unrelated code you're saying would need to pulled into a 
> .cpp file. It looks like there's only one actual call to 
> `TI.isAddressSpaceSupersetOf`, so if you just pass around an `ASTContext &` 
> to that point, nothing else will need to drill into it. And frankly that 
> entire expression in `Qualifiers::isAddressSpaceSupersetOf` after the 
> equality check is so unwieldy that it probably ought to have been pulled into 
> a .cpp file a long time ago.

The checks for ` bool isMoreQualifiedThan` in 
`clang/include/clang/AST/CanonicalType.h`. This is included by `ASTContext.h` 
and doesn't have a `.cpp` file so I'd need to find somewhere to put it.

https://github.com/llvm/llvm-project/pull/115777
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to