NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
I sometimes wish ASTContext methods just didn't crash :)
Oh well, let's just see if more problems show up.
================
Comment at: lib/StaticAnalyzer/Checkers/CastToStructChecker.cpp:93
// Warn when there is widening cast.
unsigned ToWidth = Ctx.getTypeInfo(ToPointeeTy).Width;
----------------
I think we should move the check here then. That'd avoid double-checking if
`ToPointeeTy` is a record type (we could `cast<>` directly on this branch).
Repository:
rL LLVM
https://reviews.llvm.org/D28297
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
