================ @@ -769,7 +769,7 @@ bool AArch64TargetInfo::hasFeature(StringRef Feature) const { .Case("f32mm", FPU & SveMode && HasMatmulFP32) .Case("f64mm", FPU & SveMode && HasMatmulFP64) .Case("sve2", FPU & SveMode && HasSVE2) - .Case("sve2-pmull128", FPU & SveMode && HasSVE2AES) + .Case("sve-aes", HasSVEAES) ---------------- labrinea wrote:
The function AArch64TargetInfo::hasFeature doesn't seem to be used much. I don't see any particular tests for it neither it is clear whether the stringswitch should be handling backend feature names or command line facing feature names. I bet most of the cases are useless. That said it doesn't seem necessary to add a line for `.Case("sve2-aes", HasSVE2 && HasSVEAES)` I guess. https://github.com/llvm/llvm-project/pull/116026 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits