ShashwathiNavada wrote:

> Thanks for this patch. Could you update the title/summary of the patch to say 
> that seq_cst is allowed in Flush since OpenMP 5.1. Also, might make sense to 
> say why no other changes in Lowering to IR is required.
> 
> Could you add a test in flang/test/Lower/OpenMP/flush.f90 also for the Flang 
> lowering?

@kiranchandramohan Thanks for the comment! I noticed this test doesn't cover 
other flush clauses like acq_rel, acquire or release. Do you think we need to 
add seq_cst specifically?

https://github.com/llvm/llvm-project/pull/114072
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to