ChuanqiXu9 wrote: > I think it's reasonable to do something similar here, but I believe the > change for that should be inside GetOrCreateLLVMGlobal, not in > GetAddrOfGlobalVar.
The problem to make it in `GetOrCreateLLVMGlobal` is that the argument of `Ty` is not skippable. So the semantics is slightly odd. Currently I feel it makes more or less sense that we can do some decisions if the user of `GetAddrOfGlobalVar` don't specify a Type, which implies the user doesn't care about the type. https://github.com/llvm/llvm-project/pull/114948 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
