Author: Jaime González Date: 2024-11-05T11:41:49-05:00 New Revision: 52624d77c9d541dc6adccdbfea6e981e8e8079b8
URL: https://github.com/llvm/llvm-project/commit/52624d77c9d541dc6adccdbfea6e981e8e8079b8 DIFF: https://github.com/llvm/llvm-project/commit/52624d77c9d541dc6adccdbfea6e981e8e8079b8.diff LOG: [clang] Check '-Wp,' arg has values before accesing (#113677) Executing `clang -Wp,` without any argument value causes Undefined Behavior due to accessing a SmallVector without elements Executing clang in debug mode raises an assert and Valgrind complains as follow: ``` $ valgrind bin/clang -Wp, ==18620== Memcheck, a memory error detector ==18620== Copyright (C) 2002-2022, and GNU GPL'd, by Julian Seward et al. ==18620== Using Valgrind-3.22.0 and LibVEX; rerun with -h for copyright info ==18620== Command: bin/clang -Wp, ==18620== ==18620== Conditional jump or move depends on uninitialised value(s) ==18620== at 0x44F215B: clang::driver::Driver::TranslateInputArgs(llvm::opt::InputArgList const&) const (in /home/jaime/devel/llvm-project/build/bin/clang-20) ==18620== by 0x4515831: clang::driver::Driver::BuildCompilation(llvm::ArrayRef<char const*>) (in /home/jaime/devel/llvm-project/build/bin/clang-20) ==18620== by 0x10B3435: clang_main(int, char**, llvm::ToolContext const&) (in /home/jaime/devel/llvm-project/build/bin/clang-20) ==18620== by 0xF78F99: main (in /home/jaime/devel/llvm-project/build/bin/clang-20) ==18620== ... ``` Added: Modified: clang/lib/Driver/Driver.cpp Removed: ################################################################################ diff --git a/clang/lib/Driver/Driver.cpp b/clang/lib/Driver/Driver.cpp index c5be122737051e..93e85f7dffe35a 100644 --- a/clang/lib/Driver/Driver.cpp +++ b/clang/lib/Driver/Driver.cpp @@ -454,6 +454,7 @@ DerivedArgList *Driver::TranslateInputArgs(const InputArgList &Args) const { // some build systems. We don't try to be complete here because we don't // care to encourage this usage model. if (A->getOption().matches(options::OPT_Wp_COMMA) && + A->getNumValues() > 0 && (A->getValue(0) == StringRef("-MD") || A->getValue(0) == StringRef("-MMD"))) { // Rewrite to -MD/-MMD along with -MF. _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
