rsmith added a comment.
Looks good, though there are some `value_type` constructors left. I've not
checked the standard to see if they are all declared with `charT`.
================
Comment at: include/string:782
_LIBCPP_INLINE_VISIBILITY
basic_string(const value_type* __s, size_type __n);
_LIBCPP_INLINE_VISIBILITY
----------------
Did you skip this one intentionally?
================
Comment at: include/string:788
_LIBCPP_INLINE_VISIBILITY
basic_string(size_type __n, value_type __c, const allocator_type& __a);
basic_string(const basic_string& __str, size_type __pos, size_type __n,
----------------
Likewise these two.
================
Comment at: include/string:812
_LIBCPP_INLINE_VISIBILITY
basic_string(initializer_list<value_type> __il, const allocator_type& __a);
#endif // _LIBCPP_HAS_NO_GENERALIZED_INITIALIZERS
----------------
And these
https://reviews.llvm.org/D29863
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
