================
@@ -10,4 +10,57 @@
 //
 
//===----------------------------------------------------------------------===//
 
-#include <clang/CIR/Dialect/IR/CIRDialect.h>
+#include "clang/CIR/Dialect/IR/CIRDialect.h"
+
+#include "mlir/Support/LogicalResult.h"
+
+#include "clang/CIR/Dialect/IR/CIROpsDialect.cpp.inc"
----------------
dkolsen-pgi wrote:

The first of the three includes here is the header file for this source file.  
In some coding standards that header should always be first.  Does Clang have 
that convention?

The last of the three includes is the TableGen-generated implementation file.  
I feel like that should always be last.  Is there a Clang or LLVM convention 
about where that should go?

That leaves only one include, the middle one, that needs to be alphabetized.


https://github.com/llvm/llvm-project/pull/113483
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to