alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG with a few comments.
================
Comment at: clang-tidy/modernize/UseUsingCheck.h:24
class UseUsingCheck : public ClangTidyCheck {
+
public:
----------------
nit: empty line
================
Comment at: clang-tidy/modernize/UseUsingCheck.h:32
+private:
+ const bool MacroWarning;
};
----------------
nit: `MacroWarning` doesn't sound right to me. Maybe `WarnInMacros` or even
`IgnoreMacros` (defaulting to `true`)?
================
Comment at: test/clang-tidy/modernize-use-using.cpp:154
+// CHECK-MESSAGES: :[[@LINE-1]]:3: warning: use 'using' instead of 'typedef'
+// CHECK-FIXES: using FuncType = my_cclass
+}
----------------
Why no trailing semicolon?
https://reviews.llvm.org/D29262
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
