rmaprath added a comment. In https://reviews.llvm.org/D29630#670876, @EricWF wrote:
> In https://reviews.llvm.org/D29630#670873, @rmaprath wrote: > > > Sorry for the delay, I've updated the patch with all the comments addressed. > > > > @EricWF: Got one question before I commit: The `sleep_for` function in the > > dylib (`thread.cpp`) is now quite small. Is there a particular reason to > > keep it there? I was wondering if we should move that bit to the `<thread>` > > header altogether. > > > Removing the definition in the dylib would be ABI breaking. Ah! of course. Thanks. https://reviews.llvm.org/D29630 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
