llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang Author: Helena Kotas (hekota) <details> <summary>Changes</summary> --- Full diff: https://github.com/llvm/llvm-project/pull/113649.diff 4 Files Affected: - (modified) clang/lib/Sema/HLSLExternalSemaSource.cpp (+2-13) - (modified) clang/test/AST/HLSL/RWBuffer-AST.hlsl (+1-1) - (modified) clang/test/AST/HLSL/RWStructuredBuffer-AST.hlsl (+1-1) - (modified) clang/test/AST/HLSL/StructuredBuffer-AST.hlsl (+1-1) ``````````diff diff --git a/clang/lib/Sema/HLSLExternalSemaSource.cpp b/clang/lib/Sema/HLSLExternalSemaSource.cpp index ce8564429b3802..a8365448de7246 100644 --- a/clang/lib/Sema/HLSLExternalSemaSource.cpp +++ b/clang/lib/Sema/HLSLExternalSemaSource.cpp @@ -14,8 +14,6 @@ #include "clang/AST/Attr.h" #include "clang/AST/DeclCXX.h" #include "clang/AST/Type.h" -#include "clang/Basic/AttrKinds.h" -#include "clang/Basic/HLSLRuntime.h" #include "clang/Basic/SourceLocation.h" #include "clang/Sema/Lookup.h" #include "clang/Sema/Sema.h" @@ -164,16 +162,7 @@ struct BuiltinTypeDeclBuilder { VD, false, NameInfo, Ty, VK_PRValue); } - static Expr *emitResourceClassExpr(ASTContext &AST, ResourceClass RC) { - return IntegerLiteral::Create( - AST, - llvm::APInt(AST.getIntWidth(AST.UnsignedCharTy), - static_cast<uint8_t>(RC)), - AST.UnsignedCharTy, SourceLocation()); - } - - BuiltinTypeDeclBuilder &addDefaultHandleConstructor(Sema &S, - ResourceClass RC) { + BuiltinTypeDeclBuilder &addDefaultHandleConstructor(Sema &S) { if (Record->isCompleteDefinition()) return *this; ASTContext &AST = Record->getASTContext(); @@ -480,7 +469,7 @@ static BuiltinTypeDeclBuilder setupBufferType(CXXRecordDecl *Decl, Sema &S, bool IsROV, bool RawBuffer) { return BuiltinTypeDeclBuilder(Decl) .addHandleMember(S, RC, RK, IsROV, RawBuffer) - .addDefaultHandleConstructor(S, RC); + .addDefaultHandleConstructor(S); } void HLSLExternalSemaSource::defineHLSLTypesWithForwardDeclarations() { diff --git a/clang/test/AST/HLSL/RWBuffer-AST.hlsl b/clang/test/AST/HLSL/RWBuffer-AST.hlsl index e6ce73dbd962f7..ebddd72ddb1e0e 100644 --- a/clang/test/AST/HLSL/RWBuffer-AST.hlsl +++ b/clang/test/AST/HLSL/RWBuffer-AST.hlsl @@ -15,7 +15,7 @@ // EMPTY-NEXT: CXXRecordDecl 0x{{[0-9A-Fa-f]+}} <<invalid sloc>> <invalid sloc> implicit <undeserialized declarations> class RWBuffer // EMPTY-NEXT: FinalAttr 0x{{[0-9A-Fa-f]+}} <<invalid sloc>> Implicit final -// There should be no more occurrances of RWBuffer +// There should be no more occurrences of RWBuffer // EMPTY-NOT: RWBuffer #ifndef EMPTY diff --git a/clang/test/AST/HLSL/RWStructuredBuffer-AST.hlsl b/clang/test/AST/HLSL/RWStructuredBuffer-AST.hlsl index f95d74b30acded..4104250225aec3 100644 --- a/clang/test/AST/HLSL/RWStructuredBuffer-AST.hlsl +++ b/clang/test/AST/HLSL/RWStructuredBuffer-AST.hlsl @@ -16,7 +16,7 @@ // EMPTY-NEXT: CXXRecordDecl 0x{{[0-9A-Fa-f]+}} <<invalid sloc>> <invalid sloc> implicit <undeserialized declarations> class RWStructuredBuffer // EMPTY-NEXT: FinalAttr 0x{{[0-9A-Fa-f]+}} <<invalid sloc>> Implicit final -// There should be no more occurrances of RWStructuredBuffer +// There should be no more occurrences of RWStructuredBuffer // EMPTY-NOT: {{[^[:alnum:]]}}RWStructuredBuffer #ifndef EMPTY diff --git a/clang/test/AST/HLSL/StructuredBuffer-AST.hlsl b/clang/test/AST/HLSL/StructuredBuffer-AST.hlsl index 6c39be8ba519f9..42a7d1b5617397 100644 --- a/clang/test/AST/HLSL/StructuredBuffer-AST.hlsl +++ b/clang/test/AST/HLSL/StructuredBuffer-AST.hlsl @@ -16,7 +16,7 @@ // EMPTY-NEXT: CXXRecordDecl 0x{{[0-9A-Fa-f]+}} <<invalid sloc>> <invalid sloc> implicit <undeserialized declarations> class StructuredBuffer // EMPTY-NEXT: FinalAttr 0x{{[0-9A-Fa-f]+}} <<invalid sloc>> Implicit final -// There should be no more occurrances of StructuredBuffer +// There should be no more occurrences of StructuredBuffer // EMPTY-NOT: {{[^[:alnum:]]}}StructuredBuffer #ifndef EMPTY `````````` </details> https://github.com/llvm/llvm-project/pull/113649 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
