llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang-driver Author: Kazu Hirata (kazutakahirata) <details> <summary>Changes</summary> --- Full diff: https://github.com/llvm/llvm-project/pull/113651.diff 1 Files Affected: - (modified) clang/lib/Driver/ToolChains/Clang.cpp (+5-5) ``````````diff diff --git a/clang/lib/Driver/ToolChains/Clang.cpp b/clang/lib/Driver/ToolChains/Clang.cpp index 06c44a660e98fb..04b3832327a99c 100644 --- a/clang/lib/Driver/ToolChains/Clang.cpp +++ b/clang/lib/Driver/ToolChains/Clang.cpp @@ -2838,7 +2838,7 @@ static std::string ComplexArithmeticStr(LangOptions::ComplexRangeKind Range) { static void EmitComplexRangeDiag(const Driver &D, std::string str1, std::string str2) { - if ((str1.compare(str2) != 0) && !str2.empty() && !str1.empty()) { + if (str1 != str2 && !str2.empty() && !str1.empty()) { D.Diag(clang::diag::warn_drv_overriding_option) << str1 << str2; } } @@ -2996,8 +2996,8 @@ static void RenderFloatingPointOptions(const ToolChain &TC, const Driver &D, EmitComplexRangeDiag(D, RenderComplexRangeOption(Range), "-fno-cx-limited-range"); } else { - if (GccRangeComplexOption.compare("-fcx-limited-range") != 0 && - GccRangeComplexOption.compare("-fno-cx-fortran-rules") != 0) + if (GccRangeComplexOption != "-fcx-limited-range" && + GccRangeComplexOption != "-fno-cx-fortran-rules") EmitComplexRangeDiag(D, GccRangeComplexOption, "-fno-cx-limited-range"); } @@ -3042,8 +3042,8 @@ static void RenderFloatingPointOptions(const ToolChain &TC, const Driver &D, break; } if (!GccRangeComplexOption.empty()) { - if (GccRangeComplexOption.compare("-fcx-limited-range") != 0) { - if (GccRangeComplexOption.compare("-fcx-fortran-rules") != 0) { + if (GccRangeComplexOption != "-fcx-limited-range") { + if (GccRangeComplexOption != "-fcx-fortran-rules") { if (RangeVal != LangOptions::ComplexRangeKind::CX_Improved) EmitComplexRangeDiag(D, GccRangeComplexOption, ComplexArithmeticStr(RangeVal)); `````````` </details> https://github.com/llvm/llvm-project/pull/113651 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
