aprantl added a comment. Few more inline comments. I think the code itself is looking good now. Why doesn't this patch include any test cases? I would have expected some that exercise the command line include handling, etc., ...
================ Comment at: lib/CodeGen/MacroPPCallbacks.h:35 + + /// Counts current number of command line included files, which was entered + /// and was not exited yet. ---------------- s/was/were/ ================ Comment at: lib/CodeGen/MacroPPCallbacks.h:37 + /// and was not exited yet. + int CommandIncludeFiles = 0; + ---------------- What about EnteredCommandLineIncludes or EnteredCommandLineIncludeFiles? https://reviews.llvm.org/D16135 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
