[PATCH] D29530: [ubsan] Reduce null checking of C++ object pointers (PR27581)

[Alex Lorenz via Phabricator via cfe-commits]

arphaman added a comment.

I feel like you should have at least one statement in the test that uses 
explicit 'this' to access a field/method.

Does your patch handle fields/methods in base classes as well? I think 'this' 
might be implicitly converted in the base of the member expression.

Also, what about cases like this one:

  struct A {
    int x;
  
    void methodNotConst() const {
      const_cast<A*>(this)->x = 0;
    }
  };




https://reviews.llvm.org/D29530



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits