EricWF added a comment.

Since all of these changes are for libc++ specific tests I would much rather 
see changes of this form:

  #if defined(_LIBCPP_VERSION)
  {
    typedef foo bar;
    static_assert(baz, "");
  }
  #endif

I think that's a lot nicer than wrapping every statement in the block in a 
`LIBCPP_ONLY`.
If you agree feel free to commit those changes without review.


https://reviews.llvm.org/D29135



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to