idlecode added inline comments.

================
Comment at: lib/Format/Format.cpp:1182
+         I != E; ++I)
+      LastToNextLineFirst[(*I)->Last] = (*std::next(I))->First;
     tooling::Replacements Fixes;
----------------
Could you add brackets around loop body?


================
Comment at: lib/Format/Format.cpp:1184
     tooling::Replacements Fixes;
     std::vector<FormatToken *> Tokens;
     std::copy(DeletedTokens.begin(), DeletedTokens.end(),
----------------
While you are here, could you get rid of `Tokens` vector too?
I believe iterating over `DeletedTokens`directly will do the job.


https://reviews.llvm.org/D28235



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D28235: [clang-fo... Paweł Żukowski via Phabricator via cfe-commits

Reply via email to