MrSidims wrote: > InstCombine's primary function is a canonicalization pass. You shouldn't be > modifying it for specifically SPIRV optimizations (with the exception of > SPIRV intrinsic support). SPIRV specific transforms belong in later backend > IR passes
Does it mean, that the reasoning behind this very PR is not legit? > This is problematic as it leads to optimisation passes, such as InstCombine, > getting ideas and e.g. shrinking to non byte-multiple integer types, which is > not desirable and can lead to breakage further down in the toolchain. https://github.com/llvm/llvm-project/pull/110695 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
