================
@@ -212,6 +212,25 @@ typedef llvm::ImmutableMap<const LocationContext *,
unsigned>
REGISTER_TRAIT_WITH_PROGRAMSTATE(PendingArrayDestruction,
PendingArrayDestructionMap)
+// This trait is used to heuristically filter out results produced from
+// execution paths that took "weak" assumptions within a loop.
+REGISTER_TRAIT_WITH_PROGRAMSTATE(SeenWeakLoopAssumption, bool)
+
+ProgramStateRef clang::ento::recordWeakLoopAssumption(ProgramStateRef State) {
+ return State->set<SeenWeakLoopAssumption>(true);
+}
+
+bool clang::ento::seenWeakLoopAssumption(ProgramStateRef State) {
+ return State->get<SeenWeakLoopAssumption>();
+}
----------------
NagyDonat wrote:
> Does it still worth to keep them once we finished processing the loop? The
> loop condition only gives us information while we are inside the loop the
> condition belongs to, right? Once the loop is exited, the trait could be
> safely removed I think.
No, there is a common false positive pattern where an unfounded assumption
within the loop is used _after the loop_ and produces an unwanted result at
that point. See e.g. the testcase `loop_suppress_after_zero_iterations` where
the assumption in the loop introduces `len == 0` as a separate branch, while
there is no justified reason to handle this separately.
https://github.com/llvm/llvm-project/pull/109804
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
