Alejandro =?utf-8?q?Álvarez_Ayllón?Message-ID: In-Reply-To: <llvm.org/llvm/llvm-project/pull/109...@github.com>
https://github.com/PiotrZSL commented: Code looks fine. Only thing is that existence of SuppressInlineNamespace and AlwaysSuppressInlineNamespace looks redundant. Probably one should be named SuppressRedundantInlineNamespace and other SuppressAllInlineNamespace. Otherwise it looks strange. Or even SuppressInlineNamespace should be changed from bool to some enum like None, Redundant, All. Make sure that all current test (specially from clang-tidy) still pass. https://github.com/llvm/llvm-project/pull/109147 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
