https://github.com/5chmidti requested changes to this pull request.

I've added comments for cleaning up the implementation, and also 
questions/suggestions for future enhancements that are prefixed with `~:`. I 
went with basically-NFC-cleanups, instead of improvements, in order to have 
this PR stay a `moving to clang-tidy` PR but improving the implementation 
quality.
Functionality-wise, this looks fine, but with various points that should be 
addressed to enhance the check after this lands.

https://github.com/llvm/llvm-project/pull/110471
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to