AaronBallman wrote:

Is there a need for the changes? (Are you making a significant number of 
changes in the file, or is this just a drive-by cleanup?) Generally, we don't 
do sweeping formatting changes:

> Avoid committing formatting- or whitespace-only changes outside of code you 
> plan to make subsequent changes to. Also, try to separate formatting or 
> whitespace changes from functional changes, either by correcting the format 
> first (ideally) or afterward. Such changes should be highly localized and the 
> commit message should clearly state that the commit is not intended to change 
> functionality, usually by stating it is NFC. (From 
> https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access)

https://github.com/llvm/llvm-project/pull/111518
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to