================ @@ -2069,22 +2069,24 @@ bool RecursiveASTVisitor<Derived>::TraverseTemplateArgumentLocsHelper( #define DEF_TRAVERSE_TMPL_SPEC_DECL(TMPLDECLKIND, DECLKIND) \ DEF_TRAVERSE_DECL(TMPLDECLKIND##TemplateSpecializationDecl, { \ + auto TSK = D->getTemplateSpecializationKind(); \ /* For implicit instantiations ("set<int> x;"), we don't want to \ recurse at all, since the instatiated template isn't written in \ the source code anywhere. (Note the instatiated *type* -- \ set<int> -- is written, and will still get a callback of \ TemplateSpecializationType). For explicit instantiations \ ("template set<int>;"), we do need a callback, since this \ - is the only callback that's made for this instantiation. \ - We use getTemplateArgsAsWritten() to distinguish. */ \ - if (const auto *ArgsWritten = D->getTemplateArgsAsWritten()) { \ - /* The args that remains unspecialized. */ \ - TRY_TO(TraverseTemplateArgumentLocsHelper( \ - ArgsWritten->getTemplateArgs(), ArgsWritten->NumTemplateArgs)); \ + is the only callback that's made for this instantiation. */ \ + if (TSK != TSK_ImplicitInstantiation) { \ ---------------- hvdijk wrote:
But running with some extra debug checks clearly shows that that does happen, and therefore that my understanding is wrong. Okay then. However, no `TSK_Undeclared` has any `TemplateArgsAsWritten` in the testing that I ran, so all `TSK_Undeclared` were already implicitly skipped. I'm happy to explicitly skip them instead. https://github.com/llvm/llvm-project/pull/110899 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits