perry-ca wrote: > @perry-ca raised some concerns in #109664 about this functionality requiring > some context awareness, I don't think any of those is addressed by this patch > either. Pretty much all of the callers apart from ASTReader is just using > `IsText = true`.
It just happens that 90% of the time you are dealing with text files. As you noted, in the context of the ASTReader, the file being read is expected to be a binary file. In that case the parameter is false. These change mirror interface to `getFileOrSTDIN()` which has a IsText parameter. This does touch a number of places but I feel the changes are in line with the rest of the file I/O functions in llvm. https://github.com/llvm/llvm-project/pull/110661 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
