================ @@ -0,0 +1,67 @@ +//===--- NondetermnisticPointerUsageCheck.cpp - clang-tidy ------------===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +#include "NondeterministicPointerUsageCheck.h" +#include "clang/AST/ASTContext.h" +#include "clang/Lex/Lexer.h" + +using namespace clang::ast_matchers; + +namespace clang::tidy::bugprone { + +void NondeterministicPointerUsageCheck::registerMatchers(MatchFinder *Finder) { + + auto LoopVariable = varDecl(hasType(hasCanonicalType(pointerType()))); + + auto RangeInit = declRefExpr(to(varDecl(hasType(recordDecl( + anyOf(hasName("std::unordered_set"), hasName("std::unordered_map"), + hasName("std::unordered_multiset"), + hasName("std::unordered_multimap"))))))); + + Finder->addMatcher( + stmt(cxxForRangeStmt(hasRangeInit(RangeInit.bind("rangeinit")), + hasLoopVariable(LoopVariable.bind("loopVar")))) + .bind("cxxForRangeStmt"), + this); + + auto SortFuncM = anyOf(callee(functionDecl(hasName("std::is_sorted"))), + callee(functionDecl(hasName("std::nth_element"))), + callee(functionDecl(hasName("std::sort"))), + callee(functionDecl(hasName("std::partial_sort"))), + callee(functionDecl(hasName("std::partition"))), + callee(functionDecl(hasName("std::stable_partition"))), + callee(functionDecl(hasName("std::stable_sort")))); + + auto IteratesPointerEltsM = hasArgument( + 0, + cxxMemberCallExpr(on(hasType(cxxRecordDecl(has(fieldDecl(hasType( + hasCanonicalType(pointsTo(hasCanonicalType(pointerType()))))))))))); ---------------- earnol wrote:
It is a useful checker. However it does not match for complex cases. I suggest to match not only pointers but also objects of type: [std::reference_wrapper](http://en.cppreference.com/w/cpp/utility/functional/reference_wrapper). Those objects are essentially references transformed into pointers and thus can expose the same behavior. Please look into [example](https://godbolt.org/z/rcz5dPqv1). This example should generate a warning. But i believe accounting for this case will make checker much more complex. https://github.com/llvm/llvm-project/pull/110471 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
