================
@@ -4561,6 +4569,13 @@ static void TryConstructorInitialization(Sema &S,
 
   CXXConstructorDecl *CtorDecl = cast<CXXConstructorDecl>(Best->Function);
   if (Result != OR_Deleted) {
+    if (!IsListInit && Kind.getKind() == InitializationKind::IK_Default &&
----------------
erichkeane wrote:

This is more that this line of questioning is leading me to have some 
significant doubts as to whether this is doing what it is supposed to be doing, 
and doing so in an acceptable way.  

I'm not sure how the `RecordDecl` itself can contain the information as to 
whether this initialization is initializing everything necessary, and the goofy 
diagnostics here making the problem more opaque.  You don't have ot do them 
just yet (I want to discuss this with Aaron whether that field name needs to be 
identified), but unless I'm misunderstanding this (and I'll have to spend a few 
hours debugging to figure it out to convince me), I might be against this patch.

https://github.com/llvm/llvm-project/pull/102040
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to