Author: Kadir Cetinkaya Date: 2024-09-26T14:56:34+02:00 New Revision: 9e65dcac660723a06039c7e9b30f305b9b8ca652
URL: https://github.com/llvm/llvm-project/commit/9e65dcac660723a06039c7e9b30f305b9b8ca652 DIFF: https://github.com/llvm/llvm-project/commit/9e65dcac660723a06039c7e9b30f305b9b8ca652.diff LOG: [clangd] Add some regression tests for clang-tidy finding severities Added: Modified: clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp Removed: ################################################################################ diff --git a/clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp b/clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp index efb2e5ed2fbe1d..7a47d6ebebf3b2 100644 --- a/clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp +++ b/clang-tools-extra/clangd/unittests/DiagnosticsTests.cpp @@ -1984,6 +1984,30 @@ TEST(Diagnostics, Tags) { withTag(DiagnosticTag::Deprecated))))); } +TEST(Diagnostics, TidyDiagsArentAffectedFromWerror) { + TestTU TU; + TU.ExtraArgs = {"-Werror"}; + Annotations Test(R"cpp($typedef[[typedef int INT]]; // error-ok)cpp"); + TU.Code = Test.code().str(); + TU.ClangTidyProvider = addTidyChecks("modernize-use-using"); + EXPECT_THAT( + TU.build().getDiagnostics(), + ifTidyChecks(UnorderedElementsAre( + AllOf(Diag(Test.range("typedef"), "use 'using' instead of 'typedef'"), + // Make sure severity for clang-tidy finding isn't bumped to + // error due to Werror in compile flags. + diagSeverity(DiagnosticsEngine::Warning))))); + + TU.ClangTidyProvider = + addTidyChecks("modernize-use-using", /*WarningsAsErrors=*/"modernize-*"); + EXPECT_THAT( + TU.build().getDiagnostics(), + ifTidyChecks(UnorderedElementsAre( + AllOf(Diag(Test.range("typedef"), "use 'using' instead of 'typedef'"), + // Unless bumped explicitly with WarnAsError. + diagSeverity(DiagnosticsEngine::Error))))); +} + TEST(Diagnostics, DeprecatedDiagsAreHints) { ClangdDiagnosticOptions Opts; std::optional<clangd::Diagnostic> Diag; _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
