================
@@ -4719,8 +4719,9 @@ class FunctionEffect {
NonBlocking = 1,
----------------
Sirraide wrote:
Something I only thought about just now: is `None` ever actually used?
Otherwise, we should probably just remove it and start at 0 so we don’t have to
do this `- 1` and `+ 1` dance below, because that seems like a recipe for
disaster in terms of off-by-one errors.
(Even if it is used, we should probably just use
`std::optional<FunctionEffect::Kind>` instead)
https://github.com/llvm/llvm-project/pull/99656
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
