================
@@ -583,11 +603,11 @@ class ExprEngine {
ExplodedNode *Pred,
ExplodedNodeSet &Dst);
- /// evalEagerlyAssumeBinOpBifurcation - Given the nodes in 'Src', eagerly
assume symbolic
- /// expressions of the form 'x != 0' and generate new nodes (stored in Dst)
- /// with those assumptions.
- void evalEagerlyAssumeBinOpBifurcation(ExplodedNodeSet &Dst, ExplodedNodeSet
&Src,
- const Expr *Ex);
+ /// evalEagerlyAssumeOpBifurcation - Given the nodes in 'Src', eagerly assume
+ /// symbolic expressions of the form 'x != 0' or '!x' and generate new nodes
----------------
NagyDonat wrote:
The name of this method is incorrect and misleading, which wasted my time while
I was debugging some aspect of my patch, so I want to rename it. I'm not
interested in renaming other methods, and I think it's a big waste of time to
create a separate commit for four lines of completely NFC changes. (Also,
creating a separate patch for every small change is polluting the diff log with
small inconsequential commits.)
If you have time for a systemic cleanup of this and perhaps other misnamed
methods, then feel free to create a separate commit for them; otherwise I want
to do this here.
https://github.com/llvm/llvm-project/pull/109804
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
