Author: Youngsuk Kim Date: 2024-09-25T06:12:45-05:00 New Revision: f5838cc17ffb1a0015a0d2687a72bf39b2847f6d
URL: https://github.com/llvm/llvm-project/commit/f5838cc17ffb1a0015a0d2687a72bf39b2847f6d DIFF: https://github.com/llvm/llvm-project/commit/f5838cc17ffb1a0015a0d2687a72bf39b2847f6d.diff LOG: [clang-tools-extra] Don't flush llvm::raw_string_ostream (NFC) Don't call raw_string_ostream::flush(), which is essentially a no-op. As specified in the docs, raw_string_ostream is always unbuffered. ( 65b13610a5226b84889b923bae884ba395ad084d for further reference ) Added: Modified: clang-tools-extra/clang-tidy/bugprone/ForwardDeclarationNamespaceCheck.cpp clang-tools-extra/clangd/AST.cpp clang-tools-extra/clangd/Diagnostics.cpp clang-tools-extra/clangd/FindSymbols.cpp clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/Preamble.cpp clang-tools-extra/clangd/Quality.cpp clang-tools-extra/clangd/SystemIncludeExtractor.cpp clang-tools-extra/clangd/index/StdLib.cpp clang-tools-extra/clangd/unittests/TypeHierarchyTests.cpp clang-tools-extra/include-cleaner/unittests/RecordTest.cpp clang-tools-extra/modularize/Modularize.cpp Removed: ################################################################################ diff --git a/clang-tools-extra/clang-tidy/bugprone/ForwardDeclarationNamespaceCheck.cpp b/clang-tools-extra/clang-tidy/bugprone/ForwardDeclarationNamespaceCheck.cpp index 0b38b182081947..d77df50f8fea24 100644 --- a/clang-tools-extra/clang-tidy/bugprone/ForwardDeclarationNamespaceCheck.cpp +++ b/clang-tools-extra/clang-tidy/bugprone/ForwardDeclarationNamespaceCheck.cpp @@ -107,7 +107,6 @@ static std::string getNameOfNamespace(const CXXRecordDecl *Decl) { std::string Ns; llvm::raw_string_ostream OStream(Ns); NsDecl->printQualifiedName(OStream); - OStream.flush(); return Ns.empty() ? "(global)" : Ns; } diff --git a/clang-tools-extra/clangd/AST.cpp b/clang-tools-extra/clangd/AST.cpp index fda1e5fdf8d82c..333fc10f17d7b4 100644 --- a/clang-tools-extra/clangd/AST.cpp +++ b/clang-tools-extra/clangd/AST.cpp @@ -187,7 +187,6 @@ std::string printQualifiedName(const NamedDecl &ND) { // In clangd, context is usually available and paths are mostly noise. Policy.AnonymousTagLocations = false; ND.printQualifiedName(OS, Policy); - OS.flush(); assert(!StringRef(QName).starts_with("::")); return QName; } @@ -270,7 +269,6 @@ std::string printTemplateSpecializationArgs(const NamedDecl &ND) { // location information. printTemplateArgumentList(OS, Cls->getTemplateArgs().asArray(), Policy); } - OS.flush(); return TemplateArgs; } @@ -303,7 +301,6 @@ std::string printObjCMethod(const ObjCMethodDecl &Method) { OS << ", ..."; OS << ']'; - OS.flush(); return Name; } @@ -314,7 +311,6 @@ std::string printObjCContainer(const ObjCContainerDecl &C) { const ObjCInterfaceDecl *Class = Category->getClassInterface(); OS << getNameOrErrForObjCInterface(Class) << '(' << Category->getName() << ')'; - OS.flush(); return Name; } if (const ObjCCategoryImplDecl *CID = dyn_cast<ObjCCategoryImplDecl>(&C)) { @@ -322,7 +318,6 @@ std::string printObjCContainer(const ObjCContainerDecl &C) { llvm::raw_string_ostream OS(Name); const ObjCInterfaceDecl *Class = CID->getClassInterface(); OS << getNameOrErrForObjCInterface(Class) << '(' << CID->getName() << ')'; - OS.flush(); return Name; } return C.getNameAsString(); diff --git a/clang-tools-extra/clangd/Diagnostics.cpp b/clang-tools-extra/clangd/Diagnostics.cpp index 552dd36b6900bf..a8214acc50558d 100644 --- a/clang-tools-extra/clangd/Diagnostics.cpp +++ b/clang-tools-extra/clangd/Diagnostics.cpp @@ -319,7 +319,6 @@ std::string mainMessage(const Diag &D, const ClangdDiagnosticOptions &Opts) { OS << "\n\n"; printDiag(OS, Note); } - OS.flush(); return capitalize(std::move(Result)); } @@ -335,7 +334,6 @@ std::string noteMessage(const Diag &Main, const DiagBase &Note, OS << "\n\n"; printDiag(OS, Main); } - OS.flush(); return capitalize(std::move(Result)); } diff --git a/clang-tools-extra/clangd/FindSymbols.cpp b/clang-tools-extra/clangd/FindSymbols.cpp index 55f16b7085a6fe..cf2f8b62a28419 100644 --- a/clang-tools-extra/clangd/FindSymbols.cpp +++ b/clang-tools-extra/clangd/FindSymbols.cpp @@ -182,7 +182,6 @@ std::string getSymbolName(ASTContext &Ctx, const NamedDecl &ND) { OS << (Method->isInstanceMethod() ? '-' : '+'); Method->getSelector().print(OS); - OS.flush(); return Name; } return printName(Ctx, ND); diff --git a/clang-tools-extra/clangd/Hover.cpp b/clang-tools-extra/clangd/Hover.cpp index de103e011c7085..298fa79e3fd0ba 100644 --- a/clang-tools-extra/clangd/Hover.cpp +++ b/clang-tools-extra/clangd/Hover.cpp @@ -150,7 +150,6 @@ std::string printDefinition(const Decl *D, PrintingPolicy PP, std::string Definition; llvm::raw_string_ostream OS(Definition); D->print(OS, PP); - OS.flush(); return Definition; } @@ -179,7 +178,6 @@ HoverInfo::PrintedType printType(QualType QT, ASTContext &ASTCtx, OS << TT->getDecl()->getKindName() << " "; } QT.print(OS, PP); - OS.flush(); const Config &Cfg = Config::current(); if (!QT.isNull() && Cfg.Hover.ShowAKA) { @@ -229,7 +227,6 @@ HoverInfo::PrintedType printType(const TemplateTemplateParmDecl *TTP, // FIXME: TemplateTemplateParameter doesn't store the info on whether this // param was a "typename" or "class". OS << "> class"; - OS.flush(); return Result; } @@ -821,7 +818,6 @@ std::string typeAsDefinition(const HoverInfo::PrintedType &PType) { OS << PType.Type; if (PType.AKA) OS << " // aka: " << *PType.AKA; - OS.flush(); return Result; } diff --git a/clang-tools-extra/clangd/Preamble.cpp b/clang-tools-extra/clangd/Preamble.cpp index 84e8fec342829c..1fe534d78daece 100644 --- a/clang-tools-extra/clangd/Preamble.cpp +++ b/clang-tools-extra/clangd/Preamble.cpp @@ -913,7 +913,6 @@ PreamblePatch PreamblePatch::create(llvm::StringRef FileName, PP.PatchedMarks = std::move(ModifiedScan->Marks); PP.PatchedMacros = std::move(ModifiedScan->Macros); dlog("Created preamble patch: {0}", Patch.str()); - Patch.flush(); return PP; } diff --git a/clang-tools-extra/clangd/Quality.cpp b/clang-tools-extra/clangd/Quality.cpp index 7371d95fbf2754..c1ab63fb22f61e 100644 --- a/clang-tools-extra/clangd/Quality.cpp +++ b/clang-tools-extra/clangd/Quality.cpp @@ -554,7 +554,6 @@ std::string sortText(float Score, llvm::StringRef Name) { llvm::write_hex(OS, encodeFloat(-Score), llvm::HexPrintStyle::Lower, /*Width=*/2 * sizeof(Score)); OS << Name; - OS.flush(); return S; } diff --git a/clang-tools-extra/clangd/SystemIncludeExtractor.cpp b/clang-tools-extra/clangd/SystemIncludeExtractor.cpp index d4b9b173d149da..c1c2e9fab96645 100644 --- a/clang-tools-extra/clangd/SystemIncludeExtractor.cpp +++ b/clang-tools-extra/clangd/SystemIncludeExtractor.cpp @@ -483,7 +483,6 @@ std::string convertGlobToRegex(llvm::StringRef Glob) { } } RegStream << '$'; - RegStream.flush(); return RegText; } diff --git a/clang-tools-extra/clangd/index/StdLib.cpp b/clang-tools-extra/clangd/index/StdLib.cpp index 921ab5d1c96d5c..d34838a45048de 100644 --- a/clang-tools-extra/clangd/index/StdLib.cpp +++ b/clang-tools-extra/clangd/index/StdLib.cpp @@ -87,7 +87,6 @@ std::string buildUmbrella(llvm::StringLiteral Mandatory, "#endif\n", Header); } - OS.flush(); return Result; } diff --git a/clang-tools-extra/clangd/unittests/TypeHierarchyTests.cpp b/clang-tools-extra/clangd/unittests/TypeHierarchyTests.cpp index 2f82ec7444d7a9..15158d8a45ca8b 100644 --- a/clang-tools-extra/clangd/unittests/TypeHierarchyTests.cpp +++ b/clang-tools-extra/clangd/unittests/TypeHierarchyTests.cpp @@ -242,7 +242,6 @@ const NamedDecl &findDeclWithTemplateArgs(ParsedAST &AST, // Use getNameForDiagnostic() which includes the template // arguments in the printed name. ND.getNameForDiagnostic(OS, Policy, /*Qualified=*/true); - OS.flush(); return QName == Query; }); } diff --git a/clang-tools-extra/include-cleaner/unittests/RecordTest.cpp b/clang-tools-extra/include-cleaner/unittests/RecordTest.cpp index 715d95eb573464..0b05c9190cb67f 100644 --- a/clang-tools-extra/include-cleaner/unittests/RecordTest.cpp +++ b/clang-tools-extra/include-cleaner/unittests/RecordTest.cpp @@ -546,7 +546,6 @@ TEST_F(PragmaIncludeTest, IWYUExportBlock) { for (auto &FE : FEs) { OS << FE.getName() << " "; } - OS.flush(); return Result; }; auto Exporters = PI.getExporters(FM.getFile("private1.h").get(), FM); diff --git a/clang-tools-extra/modularize/Modularize.cpp b/clang-tools-extra/modularize/Modularize.cpp index 2c00c76c855336..4bb3bae0503acd 100644 --- a/clang-tools-extra/modularize/Modularize.cpp +++ b/clang-tools-extra/modularize/Modularize.cpp @@ -621,7 +621,6 @@ class CollectEntitiesVisitor std::string Name; llvm::raw_string_ostream OS(Name); ND->printQualifiedName(OS); - OS.flush(); if (Name.empty()) return true; _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
