https://github.com/Sirraide commented:
Looks good overall. As with the last pr, I don’t think anything more is gained from me staring at this for any longer. Most of the comments here are just minor things, and I think we can merge after those are addressed. One thing to note though: Do we have any tests for C? I don’t see any in this pr, but maybe I’m just being blind. https://github.com/llvm/llvm-project/pull/99656 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits