matinraayai wrote: > sorry for the delay > > after looking at MMI/MCContext, I agree that MMI shouldn't own MCContext, but > do we even need a reference from MMI to MCContext? they are different layers > of codegen IIUC. if it's possible to completely separate them we should do > that (please correct me if this doesn't make sense since I haven't spent too > much time in codegen)
@aeubanks It's not impossible to separate them completely. `MCContext` is needed during initialization and finalization of the `MachineModuleInfoWrapperPass` (and its new pass manager variant) to set the diagnostics handler. In theory, you can just pass the context to the wrapper pass instead. @arsenm any thoughts on this? https://github.com/llvm/llvm-project/pull/105541 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
