https://github.com/carlosgalvezp approved this pull request.

LGTM, thanks for splitting the patch!

Personally I don't quite see the added value of having the quotes, I actually 
find them a bit noisy. It would have been good to write the motivation for this 
change in the commit message.

But this is quite subjective so if you find that it makes the diagnostic 
clearer then I won't object.

https://github.com/llvm/llvm-project/pull/109068
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to