a.sidorin added a comment.

Amazing work, Dominic. That's what I wanted to test for long time. But, 
personally, I'm not happy with massive changes in tests.

1. I don't think that we need to change run line for tests if they pass with 
both managers. These changes are pretty noisy,
2. If Z3 is optional, we cannot enforce its usage.
3. How testing will be performed without Z3?

I think there should be a way to separate tests between RangeConstraintManager 
and Z3.
Are we going to drop RangeConstraintManager support? If no, we should care 
about backward compatibility until this happens.


https://reviews.llvm.org/D28952



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to