arphaman added inline comments.
================ Comment at: lib/Sema/SemaCodeComplete.cpp:961 + // then incorrectly applied to the target declaration. This can be avoided + // by resetting the declaration that's being hidden. + if (Hiding && isa<UsingDecl>(Hiding)) ---------------- ahatanak wrote: > I'm not sure about this, but is it correct for > VisibleDeclsRecord::checkHidden to return the UsingDecl when the > UsingShadowDecl is being passed? I'm thinking perhaps the bug is in that > function, since it seems like it should just return a nullptr instead if > UsingDecl doesn't hide UsingShadowDecl, . That makes sense I think, I've updated the code to fix `VisibleDeclsRecord::checkHidden` instead. Repository: rL LLVM https://reviews.llvm.org/D28514 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
