ABataev accepted this revision.
ABataev added a comment.
This revision is now accepted and ready to land.
LG with nits
================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:848-860
+ const StringRef outlinedHelperName, const RegionCodeGenTy &CodeGen) {
assert(ThreadIDVar->getType()->isPointerType() &&
"thread id variable must be of type kmp_int32 *");
- const CapturedStmt *CS = cast<CapturedStmt>(D.getAssociatedStmt());
CodeGenFunction CGF(CGM, true);
bool HasCancel = false;
if (auto *OPD = dyn_cast<OMPParallelDirective>(&D))
HasCancel = OPD->hasCancel();
----------------
s/outlinedHelperName/OutlinedHelperName/g
================
Comment at: lib/Sema/SemaOpenMP.cpp:1933-1937
+ StmtResult SR = S;
+ int ThisCaptureLevel =
+ getOpenMPCaptureLevels(DSAStack->getCurrentDirective());
+ while (--ThisCaptureLevel >= 0)
+ SR = ActOnCapturedRegionEnd(SR.get());
----------------
Could you move this code to `CaptureRegionUnwinderRAII`?
https://reviews.llvm.org/D28753
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
