hekota wrote:
> Is there some other way to slice this so that there's a smaller part of your > larger change that can actually be tested? The thing is that we are already using resource attributes in many places, and they all need to be updated when we switch to having the attributes on types (i.e. wrapping the handle in `HLSLAttributedResourceType`). If I slice a part off, like updating the builtin types in HLSLExternalSemaSource.cpp, change in codegen, or in register binding diagnostics, there'll be tests failing. But I hear you. I will add this back to the original change and we'll just have to deal with a larger code review. https://github.com/llvm/llvm-project/pull/106673 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
