================ @@ -530,6 +530,10 @@ struct FunctionEffectDifferences : public SmallVector<FunctionEffectDiff> { const FunctionEffectsRef &New); }; +// Defined in EffectAnalysis.cpp. TODO: Maybe make this a method of Sema and +// move more of the effects implementation into that file? +void performEffectAnalysis(Sema &S, TranslationUnitDecl *TU); ---------------- Sirraide wrote:
Yes, that should definitely be a member function of `Sema`. The implementation can go in `EffectAnalysis.cpp`. You might have to introduce a new section in the table of contents at the start of the `Sema` class for this (because yes, it’s split across so many files that it requires a table of contents at this point). https://github.com/llvm/llvm-project/pull/99656 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits