pskrgag wrote:

> Try using the Github merge workflow to avoid doing force-pushes. Those are 
> destructive for inline comments done for the PR. On force-push, GH can't 
> follow to which line it should migrate the existing inline comments, thus 
> drops them.
> 

Sorry again for fp =(. I am getting used to rebase+fp workflow, since I've 
never worked with gh flow. I am trying to switch my brain while developing 
llvm, but sometimes I mess up.

https://github.com/llvm/llvm-project/pull/102602
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to