VolatileAcorn wrote: > Whilst I can understand BinPackParameters being deprecated, as its one of the > original options I do worry a little about just how much impact such a > deprecation might have... it needs to be completely seemless because there is > ALOT of documentation references to its use on say stackoverflow. etc...
Since BinPackParameters: false / true can still be used with either approach, I assume the main worry would be that some stack overflow answer about an odd behavior / interaction of BinPackParameters that BreakParameters inherits will be less easy to find for people using the new option? >One reason I suggested making the change without renaming the option was the >level of flux the name change was having. I couldn't really see in the review >what was a change for the name/enum and what was the new behaviour. (maybe >that could be done in 2 separate commits?) I'd certainly be happy to split the changes into 2 commits, if this is the approach you all want to go with. https://github.com/llvm/llvm-project/pull/101882 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
