Sirraide wrote: > They're really great works, but I suggest we split up the patch to make the > code review easier, WDYT?
The NFC change for adding `Attr::dump()` can definitely be factored out. I don’t know about the other two because `adjustType()` handles some cases that `adjustFunctionProtoType()` doesn’t, so splitting this up would entail adding code to the latter, only to then remove it again in a follow-up patch and move it to a separate function. I personally think it’s easier to just do this in one go. https://github.com/llvm/llvm-project/pull/85325 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
