llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang Author: Dmitry Chestnykh (chestnykh) <details> <summary>Changes</summary> `BuiltinID` is not used inside `CheckBuiltinTargetInSupported` --- Full diff: https://github.com/llvm/llvm-project/pull/101650.diff 1 Files Affected: - (modified) clang/lib/Sema/SemaChecking.cpp (+5-4) ``````````diff diff --git a/clang/lib/Sema/SemaChecking.cpp b/clang/lib/Sema/SemaChecking.cpp index bb30b1e289a1c..eb816816d2d07 100644 --- a/clang/lib/Sema/SemaChecking.cpp +++ b/clang/lib/Sema/SemaChecking.cpp @@ -1862,7 +1862,7 @@ static bool CheckBuiltinTargetNotInUnsupported( // Emit an error and return true if the current architecture is not in the list // of supported architectures. static bool -CheckBuiltinTargetInSupported(Sema &S, unsigned BuiltinID, CallExpr *TheCall, +CheckBuiltinTargetInSupported(Sema &S, CallExpr *TheCall, ArrayRef<llvm::Triple::ArchType> SupportedArchs) { llvm::Triple::ArchType CurArch = S.getASTContext().getTargetInfo().getTriple().getArch(); @@ -2095,6 +2095,7 @@ Sema::CheckBuiltinFunctionCall(FunctionDecl *FDecl, unsigned BuiltinID, } FPOptions FPO; + switch (BuiltinID) { case Builtin::BI__builtin_cpu_supports: case Builtin::BI__builtin_cpu_is: @@ -2151,7 +2152,7 @@ Sema::CheckBuiltinFunctionCall(FunctionDecl *FDecl, unsigned BuiltinID, case Builtin::BI_interlockedbittestandreset_rel: case Builtin::BI_interlockedbittestandreset_nf: if (CheckBuiltinTargetInSupported( - *this, BuiltinID, TheCall, + *this, TheCall, {llvm::Triple::arm, llvm::Triple::thumb, llvm::Triple::aarch64})) return ExprError(); break; @@ -2164,7 +2165,7 @@ Sema::CheckBuiltinFunctionCall(FunctionDecl *FDecl, unsigned BuiltinID, case Builtin::BI_interlockedbittestandreset64: case Builtin::BI_interlockedbittestandset64: if (CheckBuiltinTargetInSupported( - *this, BuiltinID, TheCall, + *this, TheCall, {llvm::Triple::x86_64, llvm::Triple::arm, llvm::Triple::thumb, llvm::Triple::aarch64, llvm::Triple::amdgcn})) return ExprError(); @@ -2172,7 +2173,7 @@ Sema::CheckBuiltinFunctionCall(FunctionDecl *FDecl, unsigned BuiltinID, case Builtin::BI__builtin_set_flt_rounds: if (CheckBuiltinTargetInSupported( - *this, BuiltinID, TheCall, + *this, TheCall, {llvm::Triple::x86, llvm::Triple::x86_64, llvm::Triple::arm, llvm::Triple::thumb, llvm::Triple::aarch64, llvm::Triple::amdgcn})) return ExprError(); `````````` </details> https://github.com/llvm/llvm-project/pull/101650 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
