================ @@ -130,7 +130,7 @@ class ASTReaderListener { /// /// \returns true to indicate the options are invalid or false otherwise. virtual bool ReadLanguageOptions(const LangOptions &LangOpts, - bool Complain, + StringRef Filename, bool Complain, ---------------- ChuanqiXu9 wrote:
Let's add a comment to explain the meaning of `Filename`. It is not clear from the signature. Or we can rename the parameter to make it claer. https://github.com/llvm/llvm-project/pull/101413 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits