sfantao added inline comments.
================ Comment at: lib/CodeGen/CGOpenMPRuntime.h:250-252 + // \brief Flags associated the device global. + int32_t Flags; + ---------------- Hahnfeld wrote: > sfantao wrote: > > Hahnfeld wrote: > > > Is that intentionally not in the `protected` section below? > > Yes, we have a public getter/setter to interact with that, so no need to > > make it protected. > Hm, `Order` and `Kind` also have public getters and are currently never set > from outside - will that be required in the future? Good point, I guess those fields were being directly accessed by the child classes but now they are set through the constructor. I am privatizing the all three fields in the last diff as they don't need to be protected anymore. https://reviews.llvm.org/D28298 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
