Author: Fangrui Song Date: 2024-07-28T20:21:59-07:00 New Revision: 0953fb4c68380760562e61a5a09979359eb498c1
URL: https://github.com/llvm/llvm-project/commit/0953fb4c68380760562e61a5a09979359eb498c1 DIFF: https://github.com/llvm/llvm-project/commit/0953fb4c68380760562e61a5a09979359eb498c1.diff LOG: [Driver] Ensure -W<warning> gets HelpHidden Individual groups should not be displayed in --help. Fix two violations and change the test to prevent regression. Added: Modified: clang/include/clang/Driver/Options.td clang/test/Driver/immediate-options.c Removed: ################################################################################ diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td index ccccc95148fca..c8c56dbb51b28 100644 --- a/clang/include/clang/Driver/Options.td +++ b/clang/include/clang/Driver/Options.td @@ -978,15 +978,15 @@ def Wsystem_headers_in_module_EQ : Joined<["-"], "Wsystem-headers-in-module=">, HelpText<"Enable -Wsystem-headers when building <module>">, MarshallingInfoStringVector<DiagnosticOpts<"SystemHeaderWarningsModules">>; def Wdeprecated : Flag<["-"], "Wdeprecated">, Group<W_Group>, - Visibility<[ClangOption, CC1Option]>, + Flags<[HelpHidden]>, Visibility<[ClangOption, CC1Option]>, HelpText<"Enable warnings for deprecated constructs and define __DEPRECATED">; def Wno_deprecated : Flag<["-"], "Wno-deprecated">, Group<W_Group>, Visibility<[ClangOption, CC1Option]>; defm invalid_constexpr : BoolWOption<"invalid-constexpr", LangOpts<"CheckConstexprFunctionBodies">, Default<!strconcat("!", cpp23.KeyPath)>, - NegFlag<SetFalse, [], [ClangOption, CC1Option], "Disable">, - PosFlag<SetTrue, [], [ClangOption, CC1Option], "Enable">, + NegFlag<SetFalse, [HelpHidden], [ClangOption, CC1Option], "Disable">, + PosFlag<SetTrue, [HelpHidden], [ClangOption, CC1Option], "Enable">, BothFlags<[], [ClangOption, CC1Option], " checking of constexpr function bodies for validity within a constant expression context">>; def Wl_COMMA : CommaJoined<["-"], "Wl,">, Visibility<[ClangOption, FlangOption]>, Flags<[LinkerInput, RenderAsInput]>, diff --git a/clang/test/Driver/immediate-options.c b/clang/test/Driver/immediate-options.c index 77878fe2e9c58..b74f6b41f22a0 100644 --- a/clang/test/Driver/immediate-options.c +++ b/clang/test/Driver/immediate-options.c @@ -2,6 +2,8 @@ // HELP: isystem // HELP-NOT: ast-dump // HELP-NOT: driver-mode +// HELP: -Wa, +// HELP-NOT: -W{{[a-z][a-z]}} // Make sure that Flang-only options are not available in Clang // HELP-NOT: test-io _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
