Max =?utf-8?b?8J+RqPCfj73igI3wn5K7?= Copl Message-ID: In-Reply-To: <llvm.org/llvm/llvm-project/pull/97...@github.com>
================ @@ -3921,7 +3921,7 @@ _ForwardIterator basic_regex<_CharT, _Traits>::__parse_character_escape( if (__hd == -1) __throw_regex_error<regex_constants::error_escape>(); __sum = 16 * __sum + static_cast<unsigned>(__hd); - // fallthrough + [[clang::fallthrough]]; ---------------- vegerot wrote: Sorry, I'm new to contributing to LLVM. This was my thought process: This PR has two stacked commits. The first commit is the same commit that is in #100821. This is needed so that the CI for the second commit (which is this PR) passes. Once the first PR lands, I'll update this PR to just have a single commit. Does that make sense? If I unstack this PR now, the CI will fail. https://github.com/llvm/llvm-project/pull/97926 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits